Sure created fix https://github.com/casbin/casdoor/pull/2549
Lets deploy the helm chart only when it is changed. I see a lot of projects pick this option. The helm chart allows developers to enter the app version they want to use so they can pick any version. I will create a PR for the documentation later this week ✅
I'm not an expert of helm, also don't care much about how to use it in helm. The question here is that should not mess with version numbers in the git files. If you are hacking with updating version numbers in frequent PRs again and again, it's not a correct way to do it
Specific version numbers should be out of the git controlled file system
Created Github issue alongside PR fixes for it:
Issue
Casdoor Fix
Casdoor Helm Fix
merged
@tinder71 can you take a look at: https://github.com/casdoor/casdoor-helm/issues/8?
@tinder71 already fixed
Semantic Versioning
Issue
helm pr
casdoor pr
I see the issue. I thought semantic-release was language agnostic but it seems its really designed for nodeJS projects that contain a package.json. The original issue was to utilize semantic versioning. It may be better to manually create a release using gh tool
No. semantic-release can be used by other languages, see Casdoor (which is go): https://github.com/casbin/casdoor/releases
we use semantic-release for all languages (go, java, python, .net), etc., it's not for Node.js only
I had seen this error in the posted logs but there must be a way to configure it to not view the package.json SemanticReleaseError: Missing `package.json` file
I had copied most of the same format from casdoor originally
Like I said, take a look at how other repos (which is not Node.js) did it
Looking at this python project named pycasbin, it contains a package.json and its github action uses npx to run semantic-release.
I'll try looking for a repo without package.json
That one makes sense. https://github.com/casbin/pycasbin/blob/master/package.json you can see this package.json is only used for the semantic-release CI, it's not the same package.json file even for the Node.js project
So just add it, will do the job
I just don't know if the root folder is the only location to place it
sure, lets try it out
gimme a sec to spin up the pr
Lets see if this one does the trick https://github.com/casdoor/casdoor-helm/pull/13
There was another PR I had created for casdoor. It pushes up the git tag. We should merge this in first and then merge the helm repo pr
can you fork https://github.com/casdoor/casdoor-helm and make it right in your own repo first?
merged
The helm chart repo now shows a different error. It recognizes the package.json but requires additional information ENOPKGNAME Missing nameproperty inpackage.json.
Yes, that's why I ask you to fork this repo and test in your own place, so we don't waste PRs in official repo
Or we have to see 10+ failed PRs which seem to try different combinations of config
When your test in your repo is done, make a final PR to the official repo
I've tried a few variations in my personal repo as you suggested but seems to get one error after the next. Might be better to just revert the PR in the casdoor-helm until someone more knowledgable is able to address the semantic version feature. The casdoor pr that was merged is fine since it just pushes up git tags.
ok
