casdoor repo already pushes to dockerhub its images, did you use that credential name?
I tested more on my personal fork and discovered the issue. Turns out permissions were not the issue. It was just pointing to the wrong docker hub location. Tested on personal fork and was able to upload to docker hub on personal account with no issues. Created fresh PR https://github.com/casbin/casdoor/pull/2546. The new dockerhub location will be casbin/casdoor-helm-charts
does casbin/casdoor-helm-charts work now?
I saw https://hub.docker.com/repository/docker/casbin/casdoor-helm-charts/general was released. But the version is "0.3.0". Can we use the same version number as Casdoor?
Sure created fix https://github.com/casbin/casdoor/pull/2549
Lets deploy the helm chart only when it is changed. I see a lot of projects pick this option. The helm chart allows developers to enter the app version they want to use so they can pick any version. I will create a PR for the documentation later this week ✅
I'm not an expert of helm, also don't care much about how to use it in helm. The question here is that should not mess with version numbers in the git files. If you are hacking with updating version numbers in frequent PRs again and again, it's not a correct way to do it
Specific version numbers should be out of the git controlled file system
Created Github issue alongside PR fixes for it:
Issue
Casdoor Fix
Casdoor Helm Fix
merged
@tinder71 can you take a look at: https://github.com/casdoor/casdoor-helm/issues/8?
@tinder71 already fixed
Semantic Versioning
Issue
helm pr
casdoor pr
I see the issue. I thought semantic-release was language agnostic but it seems its really designed for nodeJS projects that contain a package.json. The original issue was to utilize semantic versioning. It may be better to manually create a release using gh tool
No. semantic-release can be used by other languages, see Casdoor (which is go): https://github.com/casbin/casdoor/releases
we use semantic-release for all languages (go, java, python, .net), etc., it's not for Node.js only
I had seen this error in the posted logs but there must be a way to configure it to not view the package.json SemanticReleaseError: Missing `package.json` file
I had copied most of the same format from casdoor originally
Like I said, take a look at how other repos (which is not Node.js) did it
Looking at this python project named pycasbin, it contains a package.json and its github action uses npx to run semantic-release.
I'll try looking for a repo without package.json
That one makes sense. https://github.com/casbin/pycasbin/blob/master/package.json you can see this package.json is only used for the semantic-release CI, it's not the same package.json file even for the Node.js project
So just add it, will do the job
I just don't know if the root folder is the only location to place it
sure, lets try it out
gimme a sec to spin up the pr
Lets see if this one does the trick https://github.com/casdoor/casdoor-helm/pull/13
There was another PR I had created for casdoor. It pushes up the git tag. We should merge this in first and then merge the helm repo pr
can you fork https://github.com/casdoor/casdoor-helm and make it right in your own repo first?
merged
1 / 48
Jan 2024
This forum runs on Casnode, an open-source forum with the look and features of Discourse, built with Go and Next.js. See what it can do on the Casnode demo site.
Try the Casnode demo